Add SDL3 support #3339
Draft
Add SDL3 support #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve button mapping and comments - Write SDL1 config in a different file
- Fix OGG playback (Wii uses tremor, playback is fine) - Prevent Fullscreen toggling via command when the setting is disabled Allowing fullscreen toggling messes up the rendering on WiiU
github-actions
bot
added
Window/Scenes
Audio
Building
Documentation
Wii
Settings
Ghabry
removed
Window/Scenes
Documentation
Wii
Settings
carstene1ns
reviewed
Jan 29, 2025
CMakeLists.txt
Outdated
| elseif(${PLAYER_AUDIO_BACKEND} STREQUAL "AESND") | ||
| target_sources(${PROJECT_NAME} PRIVATE | ||
| src/platform/wii/audio.cpp | ||
| src/platform/wii/audio.h) | ||
| target_compile_definitions(${PROJECT_NAME} PUBLIC AUDIO_AESND=1) | ||
| elseif(${PLAYER_AUDIO_BACKEND} STREQUAL ${PLAYER_TARGET_PLATFORM}) | ||
|
|
||
| elseif(${PLAYER_AUDIO_BACKED} STREQUAL "OFF") |
There was a problem hiding this comment.
At least this typo fixes the 3DS build :D
carstene1ns
reviewed
Jan 29, 2025
| if(${PLAYER_TARGET_PLATFORM} STREQUAL "SDL3") | ||
| if(${PLAYER_TARGET_PLATFORM} STREQUAL "Unset") | ||
| get_property(PLAT_PROP CACHE PLAYER_TARGET_PLATFORM PROPERTY STRINGS) | ||
| message(FATAL_ERROR "Please specify the target platform with -DPLAYER_TARGET_PLATFORM.\nOptions: ${PLAT_PROP}") |
There was a problem hiding this comment.
This needs documentation updates.
|
Also have to fix the CMake presets. Will add presets for at least SDL3 and SDL2 (if applicable) and a "default" preset where we can use a recommended default. Since inception of the presets this feature did not improve, so it will be more cartesian product preset generation (hooray). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last change before xmas is still compiling, so just opening a PR here for it.
Depends on the Wii SDL2 branch